Sort of.
"Bloat" in this case can be referred to either as inefficient code (too many lines, takes too long to read, etc.) Or there were simply too many JS scripts to handle.
exactly, each plugin is its own script, over 100 plugins/scripts :(
They tried to make a balloon dog but instead of using the long balloons Riot tried to use the ones that are only globes (🎈). You can imagine how inneficient this would end even though the globe and the loong balloons have been a proven thing to be used many times before they tried to do this
haha sort of haha
CEF Is indeed a great framework. Ember on the other hand...
Ember is great too! However, no JS framework could have saved us from the architecture choices we made.
Of course Affinity was broken! Pretty much Turn 1 wins. Standard back in Mirrodin days never stood a chance.
hahaha I appreciate the joke, I still have my affinity deck. I even splurged on foil cranial platings.
Just wondering, is it the same team that rebuilt the client, that is now trying to fix it or is there no overlap?
The group of people that initially designed the client architecture is not the same that ended up building it and re-architecting it along the way (~2016). Ownership was then transfered to a few other teams (~2017), those still maintain it today. There was a small team that improved a lot of things, nothing visible to players, tools and code re-org (2018). The new client team is a new group of people, it came together late (2019). There is some overlap, some people were part of the different projects on and off. Most of the people that worked on it in 2016 is gone now.
I dont mean to sound judgemental but how is it possible that the new client that was literally made not to have the same issues as the old one, has the same issues as the old one?
A fair question. The symptoms the client has today are similar, or the same, to the ones the old client had. However, the problems with the client today are not the same problems that the old client had. The root causes are different. So, even though we didn't repeat the mistakes of the past; other mistakes were done that lead us here.
Diffrent question, why client wasn't written using something like Qt which is a lot faster and doesnt' have more development cost then something like electron/CEF?
When picking your tech stack you got to consider other operational concerns, like:
- existing skill pool
- cost of trainning
- cost of hiring
- who are you competing for talent
- tools ecosystem
- developer community
- developer UX/efficiency
I wouldn't be able to tell you how well those were assessed when the decision to go with a web stack was made, I wasn't there. I do know QT/C++ was an option being talked about.
[deleted]
get out of here with your client talk, this is a MTG thread
1000% no BS, THIS is more important to me. The janky client getting fixed has a higher priority and impact on my enjoyment/playtime than skins, events, game modes, new games, animated series, esports anything..... Knock this out Riot! u/givanse u/The_Cactopus
Yeah, we are giving it our best shot! It impacts our enjoyment too! Thanks for your support <3
existing skill pool
cost of trainning
cost of hiring
Oh Rito smoll indie company
As of Wednesday, we are a multi-game studio. Go play some legends of runeterra ;)
I understand, but thing is Qt with Qt Quick doesn't differ much to stuff you already do (JS can be used in Qt for extending stuff and QML is like JS by itself).
My problem is that you have tons of plugins and other stuff that probably Qt would provide on its own in native like performance, instead of JS scripts that have to be JITed on each start, also you don't have to load entire giant chromium (CEF) to launch everything, instead you have Qt that is using native OS calls + small JS engine.
I mean from my perspective, Qt is as well established if not even better there including tools, UX, community, and has bigger efficiency. Even biggest CEF/Electron stuff in size pales in comparison to Plasma/KDE that proves it runs amazingly. Of course i understand that Web developers are just cheaper, but considering team for client changed few times over already due to problems, costs of training long term seems to be huge from those choices.
I understand such choices for Discord/Slack etc. where you have web client and desktop client looking the same where they share 99% of code. But there is reason why many people spit on Atom, VS code and your client.
You have valid points. There is one wrong asumption.
team for client changed few times over already due to problems
That is not the reason, not even one of them. Teams change because people leave the company, leave the industry, switch careers, start their own company, they make family decisions and move away, the company does team re-arquitecture etc.
Even if we had a QT client, a lot of stuff would need to be JS. You can't escape integrations with 3rd party web services. Plus you got to consider your deploy strategy, some stuff you'll want to deliver through a CDN, that means web. You still have to hire or train for those chunks of the client, which aren't small or trivial. This is not an argument I'm making to say –web is the clear right answer–, I'm just showing you another level of nuance.
Read morePlease go thought the client pop-ups AND REMOVE THEM, i lost a promo because "lost connection to services" while i had chat and everything in champ select lobby, and client gave me no other option than "exit", which is a dodge, which is a lost promo. Happened second time today in after game lobby, i had chat, friendlist, everything. Its clearly not working, broken, and you guys ruining our promos with this.
There is no point of this popup, or atleast give us other options than "exit".... REMOVE EVERY SINGLE POPUP THAT HAS ONLY ONE OPTION WHICH IS CLOSING THE CLIENT DOWN.... I dont understand who ever made this... what kind of programmer put things like this into the client??????????????
sorry about the frustration this is causing, please contact player support about this
When can we expect this package added to the client
https://www.npmjs.com/package/owoifyx/v/1.0.0
Hi, we appweciate ando thank youw suggestions. We'ww continyue to wowk hawd so that you can continyue to enjoy weague of wegends fow a wong whiwe.
Hey man if it makes you feel any better I never have any bugs with the client. Idk why.
That is awesome, thanks for your support.
If it helps, my discord crashes when the honor screen freezes. They also unstuck at the same time, is it because they are both built on electron?
We don't use Electron, but thanks for sticking with us and providing more info!
Think of a clock with over 100 of small screws and gears
reducing the number of plugins etc is like removing the screws and gears while the clock still continues to work
now if sth gets broken, it is easier to spot which part is broken as there are fewer parts remaining than before
The nature of web plugins is so abstract to someone that isn't a software engineer that is hard to come up with good analogies. This one is pretty close, I like it.
I love opening this article just as I get out of an ARAM and my client crashes on the honor screen, will believe it when I see it
Please report this crash by restarting the client and using the bug-report button or filling this form: https://pbr leagueoflegends.com/na/en_US/login
We haven't been able to reproduce this bug internally. We've tried to diagnose and fix it based on educated guesses. Getting more reports might help us spot a pattern.
or say its a kindergarden where everyone child can do bullshit and the fewer kids you need to observe the easier it is not to burn down the house.
LOL, accurate too!
As someone who deals with QA on a daily basis, if you dont have proper logging, you won't catch anything and then say "oh we can't reproduce this error".
Rito - have proper logging and a bunch more bugs will suddenly become reproducible on your own machines.
We have pretty good logging on a per plugin basis. It is harder to determine the sequence of events that led to a bug when multiple plugins have a bad interaction, hence the high value of collapsing them.
So much time, effort and money wasted on this...
I know, there is a lot frustration outside and inside of Riot.