I wonder if you've been thinking about third-party libs that are dependencies to your code/frameworks that you use. Do you have a common store or you ship dependencies for each plugin in their own packages?
Common store so that code is never duplicated.
150 different plugins with different build configurations sounds pretty messy. Since you said "at one point", does that mean that there are now fewer plugins, or that the client no longer uses a plugin framework?
We are down to:
- 48 plugins
- about 4 build configurations
It breaks down to 3 plugins with 3 special configs and 45 with the same build configuration. The ideal would be to get rid of the plugin system and have a single app. We are working towards that. The last few special configs are very tricky to get rid off.
[deleted]
It can make it harder sometimes. But a lot of that toxicity exists within Reddit only and not the broad player base. Sometimes players will message me (in-game) to offer encouraging words and report that they've never had a significant client issue. When that happens, I appreciate it very much, it helps too!
These are all good feature requests to enhance the collections tab. Unfortunately, the team's primary mission is to make the client more performant and reliable. We are not there yet, but as we move closer, we can look to introduce feature enhancements, we just can't commit to them until we are happy with our client improvements.
Okay, pull request incoming.
is 1,75 billion revenue not enough to hire a competent it crew and just completely remake the client?
We need more engineers, they are hard to find, send them our way:
https://www.riotgames.com/en/work-with-us/jobs
I'd like know about possibilities and/or timeframes for some improvements for collection tabs
- Champions - Integration with universe page - biographies, stories, links to other media.
- Skins - seeing descriptions in shop and being able to view skins in not only one order (by champion, by theme, so on).
- Skins - adding video previews, for example from SkinSpotlights.
I would like to know too.
u/Am1t8 when? #RitoPlease
Quick question: What version of Chromium is the team planning on upgrading the client to?
We try to upgrade to the latest stable version. But that it isn't always possible within a reasonable amount of time.
For example, the last time we upgraded Chromium we wanted to go all the way to version 80+, but had to settle for 74. On 75, some core APIs changed and upgrading our code would delay the upgrade for a couple of months. Since then, as we do other work, we improve the old code knowing that another upgrade is imminent.
how did it get this bad? what was the QA process like throughout development?
See this answer, happy to elaborate more if you would like.
https://www.reddit.com/r/leagueoflegends/comments/ldd2am/league_client_team_ama_about_the_client/gm59rgc?utm_source=share&utm_medium=web2x&context=3
First of all, thanks for the hard work! Your impact is quite noticeable, so I'm interested in seeing on what you can do.
For my question. I've been following the new client since it's early dev posts and also was one of the lucky ones to get early access to it a few years back.
Looking at early dev posts, the idea of having the client being written using web-technologies and especially using ember, was so that there can be many different teams enabled to work on the client to add features.
Since you are actively trying to find bottlenecks with features and even removing some that were especially made for this new client, looking back do you think that using this approach of using web technologies to drive the client was the right one?
The problems with the client are not inherent to the tech stack, web in this case. Many of the issues stem from the way its plugin architecture is implemented. Not even a plugin architecture is necessarily the culprit alone.
For the tech-savvy, picture this, at one point, the client was made up of over 150 plugins (web apps). All of them had their own build config (Webpack), and then, most used different versions of Webpack, Ember, Babel etc. The lack of uniformity and the boundaries that exist between features (plugins) made it very hard to maintain a improve the client.
What tech did the guys use to determine the plug in loading times? Was it an apm product or something similar?
It is just simple telemetry code in the JS that records (sends a POST) when events of interest trigger.
I'm glad they're upgrading the client... But some advice to the guy making these articles, the bottommost chart is basically unreadable for colorblind people, the colors are way too close to each other and while also being very light. I'm having a very hard time reading that graph, and my colorblindness is very mild.
Sorry about that! I will make sure the feedback is received!
Lol makes sense for them to prioritize bugs that impact their income streams. It'd be interesting to see any analysis of how these bug fixes affect their topline revenue.
We don't prioritize like that, we always think about players playing games first. Anything that prevents players from getting in game or having a good experience in game is what we prioritize. Of course we pay attention to the financial aspects, but expect to do well in that regard as the reward from delivering value first.
Now, though, we've realized if we want players to be happy, we're going to have to refactor key components of champion select.
Ha, refactoring, welp, the next two months are gonna get really bad for the devs, are you going to use the actual component as a blueprint and optimizing it or are you gonna build it from scratch?
Yep, exactly this. It'll get fun.
Ignore the negative responses (: Thanks for the work you put in
Thanks for the support <3 We'll continue to work hard (:
Most of the complaints in this reddit is just circlejerking. You have people who literally uninstalled the game years ago still come here and talk shit about Riot because they have nothing better to do.
And then you have people who have no issues 99% of the time, suddenly have an issue that fucks their promo's once and they come here raging like Riot collectively fucked their entire family and set their home on fire.
These complaints are best ignored because they add no value.
It's not like Riot can't literally fucking see error reports and know exactly how often shit breaks. The client sends them data about every crash automatically.
Complaining on reddit is the absolute least effective means of communicating with developers. Not only are most posts missed, they're also fucking worthless because the developers get none of the data that actually helps fix the issues.
"My game crashed". Oh wow, so fucking helpful. What system configuration? Hardware? Software? Network? When did it happen? How did it happen? What's between the chair and monitor?
All of that is absent in random reddit whining. It's so pointless.
What's between the chair and monitor?
ROFL
1 down, 386+ to go.
yeah, and we'll get to them :)
I've wanted this for ages but do you think the new client could have themes? Such as onr looking like the AIR client
That is A LOT of work.
Why are they using Ember.js and creating hundreds (and maybe even thousands) new instances for simplest stuff while they could use React or Vue both newer, more performant and has a centralized control mechanism (1 instance to rule them all [*1 instance and thousands of components])?
Why hundreds of Ember.js apps?
Shortest answer, we f*****p; really bad, long story.
AnotherJS newer, more performant
Link to benchmarks repository or it didn't happen.
Selenium is tricky (not 100% reliable)
What do you guys think about https://github.com/microsoft/playwright
It's
Node library to automate Chromium, Firefox and WebKit with a single API
and its goals are
It enables cross-browser web automation that is ever-green, capable, reliable and fast.
Yeah, plus, we were expecting it to do too many things for us. It has its place and I would like us to build new and better tooling with Selenium, but this time with a few very specific objectives.
In November we began prototyping what some of our new automation would look like with Puppeteer. I was not aware of the existence of Playwright. I read their repo readme and I like it very much, will definitely consider! Thanks for the info :)
Can you fix when you try to trade and then you just get stuck and can do anything else. It doesn't even trade the champ and the only way out is to quit out and guess what? Thats a dodge. Honestly it's poor considering how big the game is and the money you make from it and the most important thing, you have is the client and you can't even have one which works properly.
You wouldn't drive a car without a working steering wheel but you seem to think it's okay at riot to have a bugged client and not fix any issues.
I'm guessing this only happens sometimes? What game modes are you playing when this happens? Also, after you restart your client, filling a bug report through the client (bottom right corner), is a big help for us.